View Javadoc
1   ///////////////////////////////////////////////////////////////////////////////////////////////
2   // checkstyle: Checks Java source code and other text files for adherence to a set of rules.
3   // Copyright (C) 2001-2026 the original author or authors.
4   //
5   // This library is free software; you can redistribute it and/or
6   // modify it under the terms of the GNU Lesser General Public
7   // License as published by the Free Software Foundation; either
8   // version 2.1 of the License, or (at your option) any later version.
9   //
10  // This library is distributed in the hope that it will be useful,
11  // but WITHOUT ANY WARRANTY; without even the implied warranty of
12  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
13  // Lesser General Public License for more details.
14  //
15  // You should have received a copy of the GNU Lesser General Public
16  // License along with this library; if not, write to the Free Software
17  // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18  ///////////////////////////////////////////////////////////////////////////////////////////////
19  
20  package com.puppycrawl.tools.checkstyle.checks.javadoc;
21  
22  import java.util.ArrayList;
23  import java.util.List;
24  import java.util.Optional;
25  import java.util.function.Function;
26  import java.util.regex.Pattern;
27  import java.util.stream.Stream;
28  
29  import com.puppycrawl.tools.checkstyle.FileStatefulCheck;
30  import com.puppycrawl.tools.checkstyle.api.DetailNode;
31  import com.puppycrawl.tools.checkstyle.api.JavadocCommentsTokenTypes;
32  import com.puppycrawl.tools.checkstyle.utils.CommonUtil;
33  import com.puppycrawl.tools.checkstyle.utils.JavadocUtil;
34  
35  /**
36   * <div>
37   * Checks that
38   * <a href="https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#firstsentence">
39   * Javadoc summary sentence</a> does not contain phrases that are not recommended to use.
40   * Summaries that contain only the {@code {@inheritDoc}} tag are skipped.
41   * Summaries that contain a non-empty {@code {@return}} are allowed.
42   * Check also violate Javadoc that does not contain first sentence, though with {@code {@return}} a
43   * period is not required as the Javadoc tool adds it.
44   * </div>
45   *
46   * <p>
47   * Note: For defining a summary, both the first sentence and the @summary tag approaches
48   * are supported.
49   * </p>
50   *
51   * @since 6.0
52   */
53  @FileStatefulCheck
54  public class SummaryJavadocCheck extends AbstractJavadocCheck {
55  
56      /**
57       * A key is pointing to the warning message text in "messages.properties"
58       * file.
59       */
60      public static final String MSG_SUMMARY_FIRST_SENTENCE = "summary.first.sentence";
61  
62      /**
63       * A key is pointing to the warning message text in "messages.properties"
64       * file.
65       */
66      public static final String MSG_SUMMARY_JAVADOC = "summary.javaDoc";
67  
68      /**
69       * A key is pointing to the warning message text in "messages.properties"
70       * file.
71       */
72      public static final String MSG_SUMMARY_JAVADOC_MISSING = "summary.javaDoc.missing";
73  
74      /**
75       * A key is pointing to the warning message text in "messages.properties" file.
76       */
77      public static final String MSG_SUMMARY_MISSING_PERIOD = "summary.javaDoc.missing.period";
78  
79      /**
80       * This regexp is used to convert multiline javadoc to single-line without stars.
81       */
82      private static final Pattern JAVADOC_MULTILINE_TO_SINGLELINE_PATTERN =
83              Pattern.compile("\n[ \\t]*(\\*)|^[ \\t]*(\\*)");
84  
85      /**
86       * This regexp is used to remove html tags, whitespace, and asterisks from a string.
87       */
88      private static final Pattern HTML_ELEMENTS =
89              Pattern.compile("<[^>]*>");
90  
91      /** Default period literal. */
92      private static final String DEFAULT_PERIOD = ".";
93  
94      /**
95       * Specify the regexp for forbidden summary fragments.
96       */
97      private Pattern forbiddenSummaryFragments = CommonUtil.createPattern("^$");
98  
99      /**
100      * Specify the period symbol. Used to check the first sentence ends with a period. Periods that
101      * are not followed by a whitespace character are ignored (eg. the period in v1.0). Because some
102      * periods include whitespace built into the character, if this is set to a non-default value
103      * any period will end the sentence, whether it is followed by whitespace or not.
104      */
105     private String period = DEFAULT_PERIOD;
106 
107     /**
108      * Whether to validate untagged summary text in Javadoc.
109      */
110     private boolean shouldValidateUntaggedSummary = true;
111 
112     /**
113      * Creates a new {@code SummaryJavadocCheck} instance.
114      */
115     public SummaryJavadocCheck() {
116         // no code by default
117     }
118 
119     /**
120      * Setter to specify the regexp for forbidden summary fragments.
121      *
122      * @param pattern a pattern.
123      * @since 6.0
124      */
125     public void setForbiddenSummaryFragments(Pattern pattern) {
126         forbiddenSummaryFragments = pattern;
127     }
128 
129     /**
130      * Setter to specify the period symbol. Used to check the first sentence ends with a period.
131      * Periods that are not followed by a whitespace character are ignored (eg. the period in v1.0).
132      * Because some periods include whitespace built into the character, if this is set to a
133      * non-default value any period will end the sentence, whether it is followed by whitespace or
134      * not.
135      *
136      * @param period period's value.
137      * @since 6.2
138      */
139     public void setPeriod(String period) {
140         this.period = period;
141     }
142 
143     @Override
144     public int[] getDefaultJavadocTokens() {
145         return new int[] {
146             JavadocCommentsTokenTypes.JAVADOC_CONTENT,
147             JavadocCommentsTokenTypes.SUMMARY_INLINE_TAG,
148             JavadocCommentsTokenTypes.RETURN_INLINE_TAG,
149         };
150     }
151 
152     @Override
153     public int[] getRequiredJavadocTokens() {
154         return getAcceptableJavadocTokens();
155     }
156 
157     @Override
158     public void visitJavadocToken(DetailNode ast) {
159         if (isSummaryTag(ast) && isDefinedFirst(ast.getParent())) {
160             shouldValidateUntaggedSummary = false;
161             validateSummaryTag(ast);
162         }
163         else if (isInlineReturnTag(ast)) {
164             shouldValidateUntaggedSummary = false;
165             validateInlineReturnTag(ast);
166         }
167     }
168 
169     @Override
170     public void leaveJavadocToken(DetailNode ast) {
171         if (ast.getType() == JavadocCommentsTokenTypes.JAVADOC_CONTENT) {
172             if (shouldValidateUntaggedSummary && !startsWithInheritDoc(ast)) {
173                 validateUntaggedSummary(ast);
174             }
175             shouldValidateUntaggedSummary = true;
176         }
177     }
178 
179     /**
180      * Checks the javadoc text for {@code period} at end and forbidden fragments.
181      *
182      * @param ast the javadoc text node
183      */
184     private void validateUntaggedSummary(DetailNode ast) {
185         final String summaryDoc = getSummarySentence(ast);
186         if (summaryDoc.isEmpty()) {
187             log(ast, MSG_SUMMARY_JAVADOC_MISSING);
188         }
189         else if (!period.isEmpty()) {
190             if (summaryDoc.contains(period)) {
191                 final Optional<String> firstSentence = getFirstSentence(ast, period);
192 
193                 if (firstSentence.isPresent()) {
194                     if (containsForbiddenFragment(firstSentence.get())) {
195                         log(ast, MSG_SUMMARY_JAVADOC);
196                     }
197                 }
198                 else {
199                     log(ast, MSG_SUMMARY_FIRST_SENTENCE);
200                 }
201             }
202             else {
203                 log(ast, MSG_SUMMARY_FIRST_SENTENCE);
204             }
205         }
206     }
207 
208     /**
209      * Whether the {@code {@summary}} tag is defined first in the javadoc.
210      *
211      * @param inlineTagNode node of type {@link JavadocCommentsTokenTypes#JAVADOC_INLINE_TAG}
212      * @return {@code true} if the {@code {@summary}} tag is defined first in the javadoc
213      */
214     private static boolean isDefinedFirst(DetailNode inlineTagNode) {
215         boolean isDefinedFirst = true;
216         DetailNode currentAst = inlineTagNode.getPreviousSibling();
217         while (currentAst != null && isDefinedFirst) {
218             switch (currentAst.getType()) {
219                 case JavadocCommentsTokenTypes.TEXT ->
220                     isDefinedFirst = currentAst.getText().isBlank();
221                 case JavadocCommentsTokenTypes.HTML_ELEMENT ->
222                     isDefinedFirst = isHtmlTagWithoutText(currentAst);
223                 case JavadocCommentsTokenTypes.LEADING_ASTERISK,
224                      JavadocCommentsTokenTypes.LEADING_ASTERISKS,
225                      JavadocCommentsTokenTypes.NEWLINE -> {
226                     // Ignore formatting tokens
227                 }
228                 default -> isDefinedFirst = false;
229             }
230             currentAst = currentAst.getPreviousSibling();
231         }
232         return isDefinedFirst;
233     }
234 
235     /**
236      * Whether some text is present inside the HTML element or tag.
237      *
238      * @param node DetailNode of type {@link JavadocCommentsTokenTypes#HTML_ELEMENT}
239      * @return {@code true} if some text is present inside the HTML element
240      */
241     public static boolean isHtmlTagWithoutText(DetailNode node) {
242         boolean isEmpty = true;
243         final DetailNode htmlContentToken =
244              JavadocUtil.findFirstToken(node, JavadocCommentsTokenTypes.HTML_CONTENT);
245 
246         if (htmlContentToken != null) {
247             final DetailNode child = htmlContentToken.getFirstChild();
248             isEmpty = child.getType() == JavadocCommentsTokenTypes.HTML_ELEMENT
249                         && isHtmlTagWithoutText(child);
250         }
251         return isEmpty;
252     }
253 
254     /**
255      * Checks if the given node is an inline summary tag.
256      *
257      * @param javadocInlineTag node
258      * @return {@code true} if inline tag is of
259      *       type {@link JavadocCommentsTokenTypes#SUMMARY_INLINE_TAG}
260      */
261     private static boolean isSummaryTag(DetailNode javadocInlineTag) {
262         return javadocInlineTag.getType() == JavadocCommentsTokenTypes.SUMMARY_INLINE_TAG;
263     }
264 
265     /**
266      * Checks if the given node is an inline return node.
267      *
268      * @param javadocInlineTag node
269      * @return {@code true} if inline tag is of
270      *       type {@link JavadocCommentsTokenTypes#RETURN_INLINE_TAG}
271      */
272     private static boolean isInlineReturnTag(DetailNode javadocInlineTag) {
273         return javadocInlineTag.getType() == JavadocCommentsTokenTypes.RETURN_INLINE_TAG;
274     }
275 
276     /**
277      * Checks the inline summary (if present) for {@code period} at end and forbidden fragments.
278      *
279      * @param inlineSummaryTag node of type {@link JavadocCommentsTokenTypes#SUMMARY_INLINE_TAG}
280      */
281     private void validateSummaryTag(DetailNode inlineSummaryTag) {
282         final DetailNode descriptionNode = JavadocUtil.findFirstToken(
283                 inlineSummaryTag, JavadocCommentsTokenTypes.DESCRIPTION);
284         final String inlineSummary = getContentOfInlineCustomTag(descriptionNode);
285         final String summaryVisible = getVisibleContent(inlineSummary);
286         if (summaryVisible.isEmpty()) {
287             log(inlineSummaryTag, MSG_SUMMARY_JAVADOC_MISSING);
288         }
289         else if (!period.isEmpty()) {
290             final boolean isPeriodNotAtEnd =
291                     summaryVisible.lastIndexOf(period) != summaryVisible.length() - 1;
292             if (isPeriodNotAtEnd) {
293                 log(inlineSummaryTag, MSG_SUMMARY_MISSING_PERIOD);
294             }
295             else if (containsForbiddenFragment(inlineSummary)) {
296                 log(inlineSummaryTag, MSG_SUMMARY_JAVADOC);
297             }
298         }
299     }
300 
301     /**
302      * Checks the inline return for forbidden fragments.
303      *
304      * @param inlineReturnTag node of type {@link JavadocCommentsTokenTypes#RETURN_INLINE_TAG}
305      */
306     private void validateInlineReturnTag(DetailNode inlineReturnTag) {
307         final DetailNode descriptionNode = JavadocUtil.findFirstToken(
308                 inlineReturnTag, JavadocCommentsTokenTypes.DESCRIPTION);
309         final String inlineReturn = getContentOfInlineCustomTag(descriptionNode);
310         final String returnVisible = getVisibleContent(inlineReturn);
311         if (returnVisible.isEmpty()) {
312             log(inlineReturnTag, MSG_SUMMARY_JAVADOC_MISSING);
313         }
314         else if (containsForbiddenFragment(prependJavadocToolWord(inlineReturn))) {
315             log(inlineReturnTag, MSG_SUMMARY_JAVADOC);
316         }
317     }
318 
319     /**
320      * Gets the content of inline custom tag.
321      *
322      * @param descriptionNode node of type {@link JavadocCommentsTokenTypes#DESCRIPTION}
323      * @return String consisting of the content of inline custom tag.
324      */
325     public static String getContentOfInlineCustomTag(DetailNode descriptionNode) {
326         final StringBuilder customTagContent = new StringBuilder(256);
327         DetailNode curNode = descriptionNode;
328         while (curNode != null) {
329             if (curNode.getFirstChild() == null
330                 && !isLeadingAsterisk(curNode)) {
331                 customTagContent.append(curNode.getText());
332             }
333 
334             DetailNode toVisit = curNode.getFirstChild();
335             while (curNode != descriptionNode && toVisit == null) {
336                 toVisit = curNode.getNextSibling();
337                 curNode = curNode.getParent();
338             }
339 
340             curNode = toVisit;
341         }
342         return customTagContent.toString();
343     }
344 
345     /**
346      * Checks whether the given node is a leading asterisk.
347      *
348      * @param node the node to check
349      * @return true if the node is a leading asterisk
350      */
351     private static boolean isLeadingAsterisk(DetailNode node) {
352         return node.getType() == JavadocCommentsTokenTypes.LEADING_ASTERISK
353                 || node.getType() == JavadocCommentsTokenTypes.LEADING_ASTERISKS;
354     }
355 
356     /**
357      * Gets the string that is visible to user in javadoc.
358      *
359      * @param summary entire content of summary javadoc.
360      * @return string that is visible to user in javadoc.
361      */
362     private static String getVisibleContent(String summary) {
363         final String visibleSummary = HTML_ELEMENTS.matcher(summary).replaceAll("");
364         return visibleSummary.trim();
365     }
366 
367     /**
368      * Tests if first sentence contains forbidden summary fragment.
369      *
370      * @param firstSentence string with first sentence.
371      * @return {@code true} if first sentence contains forbidden summary fragment.
372      */
373     private boolean containsForbiddenFragment(String firstSentence) {
374         final String javadocText = JAVADOC_MULTILINE_TO_SINGLELINE_PATTERN
375                 .matcher(firstSentence).replaceAll(" ");
376         return forbiddenSummaryFragments.matcher(trimExcessWhitespaces(javadocText)).find();
377     }
378 
379     /**
380      * Prepends the word "Returns" to the given inline {@code {@return}} tag content,
381      * since Javadoc renders {@code {@return ...}} as "Returns ..." in the method summary.
382      *
383      * @param inlineReturn String consisting of the content of inline {@code {@return}} tag
384      * @return the inline return content prefixed with "Returns "
385      */
386     private static String prependJavadocToolWord(String inlineReturn) {
387         return "Returns " + inlineReturn;
388     }
389 
390     /**
391      * Trims the given {@code text} of duplicate whitespaces.
392      *
393      * @param text the text to transform.
394      * @return the finalized form of the text.
395      */
396     private static String trimExcessWhitespaces(String text) {
397         final StringBuilder result = new StringBuilder(256);
398         boolean previousWhitespace = true;
399 
400         for (int index = 0; index < text.length(); index++) {
401             final char letter = text.charAt(index);
402             final char print;
403             if (Character.isWhitespace(letter)) {
404                 if (previousWhitespace) {
405                     continue;
406                 }
407 
408                 previousWhitespace = true;
409                 print = ' ';
410             }
411             else {
412                 previousWhitespace = false;
413                 print = letter;
414             }
415 
416             result.append(print);
417         }
418 
419         return result.toString();
420     }
421 
422     /**
423      * Checks if the node starts with an {&#64;inheritDoc}.
424      *
425      * @param root the root node to examine.
426      * @return {@code true} if the javadoc starts with an {&#64;inheritDoc}.
427      */
428     private static boolean startsWithInheritDoc(DetailNode root) {
429         boolean found = false;
430         DetailNode node = root.getFirstChild();
431 
432         while (node != null) {
433             if (node.getType() == JavadocCommentsTokenTypes.JAVADOC_INLINE_TAG
434                     && node.getFirstChild().getType()
435                             == JavadocCommentsTokenTypes.INHERIT_DOC_INLINE_TAG) {
436                 found = true;
437             }
438             if ((node.getType() == JavadocCommentsTokenTypes.TEXT
439                     || node.getType() == JavadocCommentsTokenTypes.HTML_ELEMENT)
440                     && !CommonUtil.isBlank(node.getText())) {
441                 break;
442             }
443             node = node.getNextSibling();
444         }
445 
446         return found;
447     }
448 
449     /**
450      * Finds and returns summary sentence.
451      *
452      * @param ast javadoc root node.
453      * @return violation string.
454      */
455     private static String getSummarySentence(DetailNode ast) {
456         final StringBuilder result = new StringBuilder(256);
457         DetailNode node = ast.getFirstChild();
458         while (node != null) {
459             if (node.getType() == JavadocCommentsTokenTypes.TEXT) {
460                 result.append(node.getText());
461             }
462             else {
463                 final String summary = result.toString();
464                 if (CommonUtil.isBlank(summary)
465                         && node.getType() == JavadocCommentsTokenTypes.HTML_ELEMENT) {
466                     final DetailNode htmlContentToken = JavadocUtil.findFirstToken(
467                             node, JavadocCommentsTokenTypes.HTML_CONTENT);
468                     result.append(getStringInsideHtmlTag(summary, htmlContentToken));
469                 }
470             }
471             node = node.getNextSibling();
472         }
473         return result.toString().trim();
474     }
475 
476     /**
477      * Get concatenated string within text of html tags.
478      *
479      * @param result javadoc string
480      * @param detailNode htmlContent node
481      * @return java doc tag content appended in result
482      */
483     private static String getStringInsideHtmlTag(String result, DetailNode detailNode) {
484         final StringBuilder contents = new StringBuilder(result);
485         if (detailNode != null) {
486             DetailNode tempNode = detailNode.getFirstChild();
487             while (tempNode != null) {
488                 if (tempNode.getType() == JavadocCommentsTokenTypes.TEXT) {
489                     contents.append(tempNode.getText());
490                 }
491                 else {
492                     final DetailNode htmlContentToken = JavadocUtil.findFirstToken(
493                             tempNode, JavadocCommentsTokenTypes.HTML_CONTENT);
494                     contents.append(getStringInsideHtmlTag("", htmlContentToken));
495                 }
496                 tempNode = tempNode.getNextSibling();
497             }
498         }
499         return contents.toString();
500     }
501 
502     /**
503      * Finds the first sentence.
504      *
505      * @param ast The Javadoc root node.
506      * @param period The configured period symbol.
507      * @return An Optional containing the first sentence
508      *     up to and excluding the period, or an empty
509      *     Optional if no ending was found.
510      */
511     private static Optional<String> getFirstSentence(DetailNode ast, String period) {
512         final List<String> sentenceParts = new ArrayList<>();
513         Optional<String> result = Optional.empty();
514         for (String text : (Iterable<String>) streamTextParts(ast)::iterator) {
515             final Optional<String> sentenceEnding = findSentenceEnding(text, period);
516 
517             if (sentenceEnding.isPresent()) {
518                 sentenceParts.add(sentenceEnding.get());
519                 result = Optional.of(String.join("", sentenceParts));
520                 break;
521             }
522             sentenceParts.add(text);
523         }
524         return result;
525     }
526 
527     /**
528      * Streams through all the text under the given node.
529      *
530      * @param node The Javadoc node to examine.
531      * @return All the text in all nodes that have no child nodes.
532      */
533     private static Stream<String> streamTextParts(DetailNode node) {
534         final Stream<String> result;
535         if (node.getFirstChild() == null) {
536             result = Stream.of(node.getText());
537         }
538         else {
539             final List<Stream<String>> childStreams = new ArrayList<>();
540             DetailNode child = node.getFirstChild();
541             while (child != null) {
542                 childStreams.add(streamTextParts(child));
543                 child = child.getNextSibling();
544             }
545             result = childStreams.stream().flatMap(Function.identity());
546         }
547         return result;
548     }
549 
550     /**
551      * Finds the end of a sentence. The end of sentence detection here could be replaced in the
552      * future by Java's built-in BreakIterator class.
553      *
554      * @param text The string to search.
555      * @param period The period character to find.
556      * @return An Optional containing the string up to and excluding the period,
557      *     or empty Optional if no ending was found.
558      */
559     private static Optional<String> findSentenceEnding(String text, String period) {
560         int periodIndex = text.indexOf(period);
561         Optional<String> result = Optional.empty();
562         while (periodIndex >= 0) {
563             final int afterPeriodIndex = periodIndex + period.length();
564 
565             // Handle western period separately as it is only the end of a sentence if followed
566             // by whitespace. Other period characters often include whitespace in the character.
567             if (!DEFAULT_PERIOD.equals(period)
568                 || afterPeriodIndex >= text.length()
569                 || Character.isWhitespace(text.charAt(afterPeriodIndex))) {
570                 final String resultStr = text.substring(0, periodIndex);
571                 result = Optional.of(resultStr);
572                 break;
573             }
574             periodIndex = text.indexOf(period, afterPeriodIndex);
575         }
576         return result;
577     }
578 
579 }