1 /////////////////////////////////////////////////////////////////////////////////////////////// 2 // checkstyle: Checks Java source code and other text files for adherence to a set of rules. 3 // Copyright (C) 2001-2024 the original author or authors. 4 // 5 // This library is free software; you can redistribute it and/or 6 // modify it under the terms of the GNU Lesser General Public 7 // License as published by the Free Software Foundation; either 8 // version 2.1 of the License, or (at your option) any later version. 9 // 10 // This library is distributed in the hope that it will be useful, 11 // but WITHOUT ANY WARRANTY; without even the implied warranty of 12 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 // Lesser General Public License for more details. 14 // 15 // You should have received a copy of the GNU Lesser General Public 16 // License along with this library; if not, write to the Free Software 17 // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 18 /////////////////////////////////////////////////////////////////////////////////////////////// 19 20 package com.puppycrawl.tools.checkstyle.checks.annotation; 21 22 import java.util.BitSet; 23 24 import com.puppycrawl.tools.checkstyle.StatelessCheck; 25 import com.puppycrawl.tools.checkstyle.api.DetailAST; 26 import com.puppycrawl.tools.checkstyle.api.DetailNode; 27 import com.puppycrawl.tools.checkstyle.api.JavadocTokenTypes; 28 import com.puppycrawl.tools.checkstyle.api.TokenTypes; 29 import com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck; 30 import com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagInfo; 31 import com.puppycrawl.tools.checkstyle.utils.AnnotationUtil; 32 import com.puppycrawl.tools.checkstyle.utils.TokenUtil; 33 34 /** 35 * <div> 36 * Verifies that the annotation {@code @Deprecated} and the Javadoc tag 37 * {@code @deprecated} are both present when either of them is present. 38 * </div> 39 * 40 * <p> 41 * Both ways of flagging deprecation serve their own purpose. 42 * The @Deprecated annotation is used for compilers and development tools. 43 * The @deprecated javadoc tag is used to document why something is deprecated 44 * and what, if any, alternatives exist. 45 * </p> 46 * 47 * <p> 48 * In order to properly mark something as deprecated both forms of 49 * deprecation should be present. 50 * </p> 51 * 52 * <p> 53 * Package deprecation is an exception to the rule of always using the 54 * javadoc tag and annotation to deprecate. It is not clear if the javadoc 55 * tool will support it or not as newer versions keep flip-flopping on if 56 * it is supported or will cause an error. See 57 * <a href="https://bugs.openjdk.org/browse/JDK-8160601">JDK-8160601</a>. 58 * The deprecated javadoc tag is currently the only way to say why the package 59 * is deprecated and what to use instead. Until this is resolved, if you don't 60 * want to print violations on package-info, you can use a 61 * <a href="https://checkstyle.org/filters/index.html">filter</a> to ignore 62 * these files until the javadoc tool faithfully supports it. An example config 63 * using SuppressionSingleFilter is: 64 * </p> 65 * <pre> 66 * <!-- required till https://bugs.openjdk.org/browse/JDK-8160601 --> 67 * <module name="SuppressionSingleFilter"> 68 * <property name="checks" value="MissingDeprecatedCheck"/> 69 * <property name="files" value="package-info\.java"/> 70 * </module> 71 * </pre> 72 * <ul> 73 * <li> 74 * Property {@code violateExecutionOnNonTightHtml} - Control when to 75 * print violations if the Javadoc being examined by this check violates the 76 * tight html rules defined at 77 * <a href="https://checkstyle.org/writingjavadocchecks.html#Tight-HTML_rules"> 78 * Tight-HTML Rules</a>. 79 * Type is {@code boolean}. 80 * Default value is {@code false}. 81 * </li> 82 * </ul> 83 * 84 * <p> 85 * Parent is {@code com.puppycrawl.tools.checkstyle.TreeWalker} 86 * </p> 87 * 88 * <p> 89 * Violation Message Keys: 90 * </p> 91 * <ul> 92 * <li> 93 * {@code annotation.missing.deprecated} 94 * </li> 95 * <li> 96 * {@code javadoc.duplicateTag} 97 * </li> 98 * <li> 99 * {@code javadoc.missed.html.close} 100 * </li> 101 * <li> 102 * {@code javadoc.parse.rule.error} 103 * </li> 104 * <li> 105 * {@code javadoc.unclosedHtml} 106 * </li> 107 * <li> 108 * {@code javadoc.wrong.singleton.html.tag} 109 * </li> 110 * </ul> 111 * 112 * @since 5.0 113 */ 114 @StatelessCheck 115 public final class MissingDeprecatedCheck extends AbstractJavadocCheck { 116 117 /** 118 * A key is pointing to the warning message text in "messages.properties" 119 * file. 120 */ 121 public static final String MSG_KEY_ANNOTATION_MISSING_DEPRECATED = 122 "annotation.missing.deprecated"; 123 124 /** 125 * A key is pointing to the warning message text in "messages.properties" 126 * file. 127 */ 128 public static final String MSG_KEY_JAVADOC_DUPLICATE_TAG = 129 "javadoc.duplicateTag"; 130 131 /** {@link Deprecated Deprecated} annotation name. */ 132 private static final String DEPRECATED = "Deprecated"; 133 134 /** Fully-qualified {@link Deprecated Deprecated} annotation name. */ 135 private static final String FQ_DEPRECATED = "java.lang." + DEPRECATED; 136 137 /** Token types to find parent of. */ 138 private static final BitSet TYPES_HASH_SET = TokenUtil.asBitSet( 139 TokenTypes.TYPE, TokenTypes.MODIFIERS, TokenTypes.ANNOTATION, 140 TokenTypes.ANNOTATIONS, TokenTypes.ARRAY_DECLARATOR, 141 TokenTypes.TYPE_PARAMETERS, TokenTypes.DOT); 142 143 @Override 144 public int[] getDefaultJavadocTokens() { 145 return getRequiredJavadocTokens(); 146 } 147 148 @Override 149 public int[] getRequiredJavadocTokens() { 150 return new int[] { 151 JavadocTokenTypes.JAVADOC, 152 }; 153 } 154 155 @Override 156 public void visitJavadocToken(DetailNode ast) { 157 final DetailAST parentAst = getParent(getBlockCommentAst()); 158 159 final boolean containsAnnotation = 160 AnnotationUtil.containsAnnotation(parentAst, DEPRECATED) 161 || AnnotationUtil.containsAnnotation(parentAst, FQ_DEPRECATED); 162 163 final boolean containsJavadocTag = containsDeprecatedTag(ast); 164 165 if (containsAnnotation ^ containsJavadocTag) { 166 log(parentAst.getLineNo(), MSG_KEY_ANNOTATION_MISSING_DEPRECATED); 167 } 168 } 169 170 /** 171 * Checks to see if the javadoc contains a deprecated tag. 172 * 173 * @param javadoc the javadoc of the AST 174 * @return true if contains the tag 175 */ 176 private boolean containsDeprecatedTag(DetailNode javadoc) { 177 boolean found = false; 178 for (DetailNode child : javadoc.getChildren()) { 179 if (child.getType() == JavadocTokenTypes.JAVADOC_TAG 180 && child.getChildren()[0].getType() == JavadocTokenTypes.DEPRECATED_LITERAL) { 181 if (found) { 182 log(child.getLineNumber(), MSG_KEY_JAVADOC_DUPLICATE_TAG, 183 JavadocTagInfo.DEPRECATED.getText()); 184 } 185 found = true; 186 } 187 } 188 return found; 189 } 190 191 /** 192 * Returns the parent node of the comment. 193 * 194 * @param commentBlock child node. 195 * @return parent node. 196 */ 197 private static DetailAST getParent(DetailAST commentBlock) { 198 DetailAST result = commentBlock.getParent(); 199 200 if (TokenUtil.isRootNode(result)) { 201 result = commentBlock.getNextSibling(); 202 } 203 204 while (true) { 205 final int type = result.getType(); 206 if (TYPES_HASH_SET.get(type)) { 207 result = result.getParent(); 208 } 209 else if (type == TokenTypes.SINGLE_LINE_COMMENT) { 210 result = result.getNextSibling(); 211 } 212 else { 213 break; 214 } 215 } 216 217 return result; 218 } 219 220 }