View Javadoc
1   ///////////////////////////////////////////////////////////////////////////////////////////////
2   // checkstyle: Checks Java source code and other text files for adherence to a set of rules.
3   // Copyright (C) 2001-2026 the original author or authors.
4   //
5   // This library is free software; you can redistribute it and/or
6   // modify it under the terms of the GNU Lesser General Public
7   // License as published by the Free Software Foundation; either
8   // version 2.1 of the License, or (at your option) any later version.
9   //
10  // This library is distributed in the hope that it will be useful,
11  // but WITHOUT ANY WARRANTY; without even the implied warranty of
12  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
13  // Lesser General Public License for more details.
14  //
15  // You should have received a copy of the GNU Lesser General Public
16  // License along with this library; if not, write to the Free Software
17  // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18  ///////////////////////////////////////////////////////////////////////////////////////////////
19  
20  package com.puppycrawl.tools.checkstyle.checks.annotation;
21  
22  import java.util.BitSet;
23  
24  import com.puppycrawl.tools.checkstyle.StatelessCheck;
25  import com.puppycrawl.tools.checkstyle.api.DetailAST;
26  import com.puppycrawl.tools.checkstyle.api.DetailNode;
27  import com.puppycrawl.tools.checkstyle.api.JavadocCommentsTokenTypes;
28  import com.puppycrawl.tools.checkstyle.api.TokenTypes;
29  import com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck;
30  import com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagInfo;
31  import com.puppycrawl.tools.checkstyle.utils.AnnotationUtil;
32  import com.puppycrawl.tools.checkstyle.utils.TokenUtil;
33  
34  /**
35   * <div>
36   * Verifies that the annotation {@code @Deprecated} and the Javadoc tag
37   * {@code @deprecated} are both present when either of them is present.
38   * </div>
39   *
40   * <p>
41   * Both ways of flagging deprecation serve their own purpose.
42   * The &#64;Deprecated annotation is used for compilers and development tools.
43   * The &#64;deprecated javadoc tag is used to document why something is deprecated
44   * and what, if any, alternatives exist.
45   * </p>
46   *
47   * <p>
48   * In order to properly mark something as deprecated both forms of
49   * deprecation should be present.
50   * </p>
51   *
52   * <p>
53   * Package deprecation is an exception to the rule of always using the
54   * javadoc tag and annotation to deprecate. It is not clear if the javadoc
55   * tool will support it or not as newer versions keep flip-flopping on if
56   * it is supported or will cause an error. See
57   * <a href="https://bugs.openjdk.org/browse/JDK-8160601">JDK-8160601</a>.
58   * The deprecated javadoc tag is currently the only way to say why the package
59   * is deprecated and what to use instead. Until this is resolved, if you don't
60   * want to print violations on package-info, you can use a
61   * <a href="https://checkstyle.org/filters/index.html">filter</a> to ignore
62   * these files until the javadoc tool faithfully supports it. An example config
63   * using SuppressionSingleFilter is:
64   * </p>
65   * <div class="wrapper"><pre class="prettyprint"><code class="language-xml">
66   * &lt;!-- required till https://bugs.openjdk.org/browse/JDK-8160601 --&gt;
67   * &lt;module name="SuppressionSingleFilter"&gt;
68   *     &lt;property name="checks" value="MissingDeprecatedCheck"/&gt;
69   *     &lt;property name="files" value="package-info\.java"/&gt;
70   * &lt;/module&gt;
71   * </code></pre></div>
72   *
73   * @since 5.0
74   */
75  @StatelessCheck
76  public final class MissingDeprecatedCheck extends AbstractJavadocCheck {
77  
78      /**
79       * A key is pointing to the warning message text in "messages.properties"
80       * file.
81       */
82      public static final String MSG_KEY_ANNOTATION_MISSING_DEPRECATED =
83              "annotation.missing.deprecated";
84  
85      /**
86       * A key is pointing to the warning message text in "messages.properties"
87       * file.
88       */
89      public static final String MSG_KEY_JAVADOC_DUPLICATE_TAG =
90              "javadoc.duplicateTag";
91  
92      /** {@link Deprecated Deprecated} annotation name. */
93      private static final String DEPRECATED = "Deprecated";
94  
95      /** Fully-qualified {@link Deprecated Deprecated} annotation name. */
96      private static final String FQ_DEPRECATED = "java.lang." + DEPRECATED;
97  
98      /** Token types to find parent of. */
99      private static final BitSet TYPES_HASH_SET = TokenUtil.asBitSet(
100             TokenTypes.TYPE, TokenTypes.MODIFIERS, TokenTypes.ANNOTATION,
101             TokenTypes.ANNOTATIONS, TokenTypes.ARRAY_DECLARATOR,
102             TokenTypes.TYPE_PARAMETERS, TokenTypes.DOT);
103 
104     @Override
105     public int[] getDefaultJavadocTokens() {
106         return getRequiredJavadocTokens();
107     }
108 
109     @Override
110     public int[] getRequiredJavadocTokens() {
111         return new int[] {
112             JavadocCommentsTokenTypes.JAVADOC_CONTENT,
113         };
114     }
115 
116     /**
117      * Setter to control when to print violations if the Javadoc being examined by this check
118      * violates the tight html rules defined at
119      * <a href="https://checkstyle.org/writingjavadocchecks.html#Tight-HTML_rules">
120      *     Tight-HTML Rules</a>.
121      *
122      * @param shouldReportViolation value to which the field shall be set to
123      * @since 8.3
124      * @propertySince 8.24
125      */
126     @Override
127     public void setViolateExecutionOnNonTightHtml(boolean shouldReportViolation) {
128         super.setViolateExecutionOnNonTightHtml(shouldReportViolation);
129     }
130 
131     @Override
132     public void visitJavadocToken(DetailNode ast) {
133         final DetailAST parentAst = getParent(getBlockCommentAst());
134 
135         final boolean containsAnnotation =
136             AnnotationUtil.containsAnnotation(parentAst, DEPRECATED)
137             || AnnotationUtil.containsAnnotation(parentAst, FQ_DEPRECATED);
138 
139         final boolean containsJavadocTag = containsDeprecatedTag(ast);
140 
141         if (containsAnnotation ^ containsJavadocTag) {
142             log(parentAst.getLineNo(), MSG_KEY_ANNOTATION_MISSING_DEPRECATED);
143         }
144     }
145 
146     /**
147      * Checks to see if the javadoc contains a deprecated tag.
148      *
149      * @param javadoc the javadoc of the AST
150      * @return true if contains the tag
151      */
152     private boolean containsDeprecatedTag(DetailNode javadoc) {
153         boolean found = false;
154         DetailNode node = javadoc.getFirstChild();
155         while (node != null) {
156             if (node.getType() == JavadocCommentsTokenTypes.JAVADOC_BLOCK_TAG
157                     && node.getFirstChild().getType()
158                             == JavadocCommentsTokenTypes.DEPRECATED_BLOCK_TAG) {
159                 if (found) {
160                     log(node.getLineNumber(), MSG_KEY_JAVADOC_DUPLICATE_TAG,
161                             JavadocTagInfo.DEPRECATED.getText());
162                 }
163                 found = true;
164             }
165             node = node.getNextSibling();
166         }
167         return found;
168     }
169 
170     /**
171      * Returns the parent node of the comment.
172      *
173      * @param commentBlock child node.
174      * @return parent node.
175      */
176     private static DetailAST getParent(DetailAST commentBlock) {
177         DetailAST result = commentBlock.getParent();
178 
179         if (TokenUtil.isRootNode(result)) {
180             result = commentBlock.getNextSibling();
181         }
182 
183         while (true) {
184             final int type = result.getType();
185             if (TYPES_HASH_SET.get(type)) {
186                 result = result.getParent();
187             }
188             else if (type == TokenTypes.SINGLE_LINE_COMMENT) {
189                 result = result.getNextSibling();
190             }
191             else {
192                 break;
193             }
194         }
195 
196         return result;
197     }
198 
199 }