1 ///////////////////////////////////////////////////////////////////////////////////////////////
2 // checkstyle: Checks Java source code and other text files for adherence to a set of rules.
3 // Copyright (C) 2001-2025 the original author or authors.
4 //
5 // This library is free software; you can redistribute it and/or
6 // modify it under the terms of the GNU Lesser General Public
7 // License as published by the Free Software Foundation; either
8 // version 2.1 of the License, or (at your option) any later version.
9 //
10 // This library is distributed in the hope that it will be useful,
11 // but WITHOUT ANY WARRANTY; without even the implied warranty of
12 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 // Lesser General Public License for more details.
14 //
15 // You should have received a copy of the GNU Lesser General Public
16 // License along with this library; if not, write to the Free Software
17 // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
18 ///////////////////////////////////////////////////////////////////////////////////////////////
19
20 package com.puppycrawl.tools.checkstyle.checks.metrics;
21
22 import java.math.BigInteger;
23 import java.util.ArrayDeque;
24 import java.util.Deque;
25
26 import com.puppycrawl.tools.checkstyle.FileStatefulCheck;
27 import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
28 import com.puppycrawl.tools.checkstyle.api.DetailAST;
29 import com.puppycrawl.tools.checkstyle.api.TokenTypes;
30 import com.puppycrawl.tools.checkstyle.utils.ScopeUtil;
31
32 /**
33 * <div>
34 * Checks cyclomatic complexity against a specified limit. It is a measure of
35 * the minimum number of possible paths through the source and therefore the
36 * number of required tests, it is not about quality of code! It is only
37 * applied to methods, c-tors,
38 * <a href="https://docs.oracle.com/javase/tutorial/java/javaOO/initial.html">
39 * static initializers and instance initializers</a>.
40 * </div>
41 *
42 * <p>
43 * The complexity is equal to the number of decision points {@code + 1}.
44 * Decision points:
45 * </p>
46 * <ul>
47 * <li>
48 * {@code if}, {@code while}, {@code do}, {@code for},
49 * {@code ?:}, {@code catch}, {@code switch}, {@code case} statements.
50 * </li>
51 * <li>
52 * Operators {@code &&} and {@code ||} in the body of target.
53 * </li>
54 * <li>
55 * {@code when} expression in case labels, also known as guards.
56 * </li>
57 * </ul>
58 *
59 * <p>
60 * By pure theory level 1-4 is considered easy to test, 5-7 OK, 8-10 consider
61 * re-factoring to ease testing, and 11+ re-factor now as testing will be painful.
62 * </p>
63 *
64 * <p>
65 * When it comes to code quality measurement by this metric level 10 is very
66 * good level as a ultimate target (that is hard to archive). Do not be ashamed
67 * to have complexity level 15 or even higher, but keep it below 20 to catch
68 * really bad-designed code automatically.
69 * </p>
70 *
71 * <p>
72 * Please use Suppression to avoid violations on cases that could not be split
73 * in few methods without damaging readability of code or encapsulation.
74 * </p>
75 * <ul>
76 * <li>
77 * Property {@code max} - Specify the maximum threshold allowed.
78 * Type is {@code int}.
79 * Default value is {@code 10}.
80 * </li>
81 * <li>
82 * Property {@code switchBlockAsSingleDecisionPoint} - Control whether to treat
83 * the whole switch block as a single decision point.
84 * Type is {@code boolean}.
85 * Default value is {@code false}.
86 * </li>
87 * <li>
88 * Property {@code tokens} - tokens to check
89 * Type is {@code java.lang.String[]}.
90 * Validation type is {@code tokenSet}.
91 * Default value is:
92 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_WHILE">
93 * LITERAL_WHILE</a>,
94 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_DO">
95 * LITERAL_DO</a>,
96 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_FOR">
97 * LITERAL_FOR</a>,
98 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_IF">
99 * LITERAL_IF</a>,
100 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_SWITCH">
101 * LITERAL_SWITCH</a>,
102 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_CASE">
103 * LITERAL_CASE</a>,
104 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_CATCH">
105 * LITERAL_CATCH</a>,
106 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#QUESTION">
107 * QUESTION</a>,
108 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LAND">
109 * LAND</a>,
110 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LOR">
111 * LOR</a>,
112 * <a href="https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_WHEN">
113 * LITERAL_WHEN</a>.
114 * </li>
115 * </ul>
116 *
117 * <p>
118 * Parent is {@code com.puppycrawl.tools.checkstyle.TreeWalker}
119 * </p>
120 *
121 * <p>
122 * Violation Message Keys:
123 * </p>
124 * <ul>
125 * <li>
126 * {@code cyclomaticComplexity}
127 * </li>
128 * </ul>
129 *
130 * @since 3.2
131 */
132 @FileStatefulCheck
133 public class CyclomaticComplexityCheck
134 extends AbstractCheck {
135
136 /**
137 * A key is pointing to the warning message text in "messages.properties"
138 * file.
139 */
140 public static final String MSG_KEY = "cyclomaticComplexity";
141
142 /** The initial current value. */
143 private static final BigInteger INITIAL_VALUE = BigInteger.ONE;
144
145 /** Default allowed complexity. */
146 private static final int DEFAULT_COMPLEXITY_VALUE = 10;
147
148 /** Stack of values - all but the current value. */
149 private final Deque<BigInteger> valueStack = new ArrayDeque<>();
150
151 /** Control whether to treat the whole switch block as a single decision point. */
152 private boolean switchBlockAsSingleDecisionPoint;
153
154 /** The current value. */
155 private BigInteger currentValue = INITIAL_VALUE;
156
157 /** Specify the maximum threshold allowed. */
158 private int max = DEFAULT_COMPLEXITY_VALUE;
159
160 /**
161 * Setter to control whether to treat the whole switch block as a single decision point.
162 *
163 * @param switchBlockAsSingleDecisionPoint whether to treat the whole switch
164 * block as a single decision point.
165 * @since 6.11
166 */
167 public void setSwitchBlockAsSingleDecisionPoint(boolean switchBlockAsSingleDecisionPoint) {
168 this.switchBlockAsSingleDecisionPoint = switchBlockAsSingleDecisionPoint;
169 }
170
171 /**
172 * Setter to specify the maximum threshold allowed.
173 *
174 * @param max the maximum threshold
175 * @since 3.2
176 */
177 public final void setMax(int max) {
178 this.max = max;
179 }
180
181 @Override
182 public int[] getDefaultTokens() {
183 return new int[] {
184 TokenTypes.CTOR_DEF,
185 TokenTypes.METHOD_DEF,
186 TokenTypes.INSTANCE_INIT,
187 TokenTypes.STATIC_INIT,
188 TokenTypes.LITERAL_WHILE,
189 TokenTypes.LITERAL_DO,
190 TokenTypes.LITERAL_FOR,
191 TokenTypes.LITERAL_IF,
192 TokenTypes.LITERAL_SWITCH,
193 TokenTypes.LITERAL_CASE,
194 TokenTypes.LITERAL_CATCH,
195 TokenTypes.QUESTION,
196 TokenTypes.LAND,
197 TokenTypes.LOR,
198 TokenTypes.COMPACT_CTOR_DEF,
199 TokenTypes.LITERAL_WHEN,
200 };
201 }
202
203 @Override
204 public int[] getAcceptableTokens() {
205 return new int[] {
206 TokenTypes.CTOR_DEF,
207 TokenTypes.METHOD_DEF,
208 TokenTypes.INSTANCE_INIT,
209 TokenTypes.STATIC_INIT,
210 TokenTypes.LITERAL_WHILE,
211 TokenTypes.LITERAL_DO,
212 TokenTypes.LITERAL_FOR,
213 TokenTypes.LITERAL_IF,
214 TokenTypes.LITERAL_SWITCH,
215 TokenTypes.LITERAL_CASE,
216 TokenTypes.LITERAL_CATCH,
217 TokenTypes.QUESTION,
218 TokenTypes.LAND,
219 TokenTypes.LOR,
220 TokenTypes.COMPACT_CTOR_DEF,
221 TokenTypes.LITERAL_WHEN,
222 };
223 }
224
225 @Override
226 public final int[] getRequiredTokens() {
227 return new int[] {
228 TokenTypes.CTOR_DEF,
229 TokenTypes.METHOD_DEF,
230 TokenTypes.INSTANCE_INIT,
231 TokenTypes.STATIC_INIT,
232 TokenTypes.COMPACT_CTOR_DEF,
233 };
234 }
235
236 @Override
237 public void visitToken(DetailAST ast) {
238 switch (ast.getType()) {
239 case TokenTypes.CTOR_DEF,
240 TokenTypes.METHOD_DEF,
241 TokenTypes.INSTANCE_INIT,
242 TokenTypes.STATIC_INIT,
243 TokenTypes.COMPACT_CTOR_DEF -> visitMethodDef();
244
245 default -> visitTokenHook(ast);
246 }
247 }
248
249 @Override
250 public void leaveToken(DetailAST ast) {
251 switch (ast.getType()) {
252 case TokenTypes.CTOR_DEF,
253 TokenTypes.METHOD_DEF,
254 TokenTypes.INSTANCE_INIT,
255 TokenTypes.STATIC_INIT,
256 TokenTypes.COMPACT_CTOR_DEF -> leaveMethodDef(ast);
257
258 default -> {
259 // Do nothing
260 }
261 }
262 }
263
264 /**
265 * Hook called when visiting a token. Will not be called the method
266 * definition tokens.
267 *
268 * @param ast the token being visited
269 */
270 private void visitTokenHook(DetailAST ast) {
271 if (switchBlockAsSingleDecisionPoint) {
272 if (!ScopeUtil.isInBlockOf(ast, TokenTypes.LITERAL_SWITCH)) {
273 incrementCurrentValue(BigInteger.ONE);
274 }
275 }
276 else if (ast.getType() != TokenTypes.LITERAL_SWITCH) {
277 incrementCurrentValue(BigInteger.ONE);
278 }
279 }
280
281 /**
282 * Process the end of a method definition.
283 *
284 * @param ast the token representing the method definition
285 */
286 private void leaveMethodDef(DetailAST ast) {
287 final BigInteger bigIntegerMax = BigInteger.valueOf(max);
288 if (currentValue.compareTo(bigIntegerMax) > 0) {
289 log(ast, MSG_KEY, currentValue, bigIntegerMax);
290 }
291 popValue();
292 }
293
294 /**
295 * Increments the current value by a specified amount.
296 *
297 * @param amount the amount to increment by
298 */
299 private void incrementCurrentValue(BigInteger amount) {
300 currentValue = currentValue.add(amount);
301 }
302
303 /** Push the current value on the stack. */
304 private void pushValue() {
305 valueStack.push(currentValue);
306 currentValue = INITIAL_VALUE;
307 }
308
309 /**
310 * Pops a value off the stack and makes it the current value.
311 */
312 private void popValue() {
313 currentValue = valueStack.pop();
314 }
315
316 /** Process the start of the method definition. */
317 private void visitMethodDef() {
318 pushValue();
319 }
320
321 }