View Javadoc
1   ///////////////////////////////////////////////////////////////////////////////////////////////
2   // checkstyle: Checks Java source code and other text files for adherence to a set of rules.
3   // Copyright (C) 2001-2024 the original author or authors.
4   //
5   // This library is free software; you can redistribute it and/or
6   // modify it under the terms of the GNU Lesser General Public
7   // License as published by the Free Software Foundation; either
8   // version 2.1 of the License, or (at your option) any later version.
9   //
10  // This library is distributed in the hope that it will be useful,
11  // but WITHOUT ANY WARRANTY; without even the implied warranty of
12  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
13  // Lesser General Public License for more details.
14  //
15  // You should have received a copy of the GNU Lesser General Public
16  // License along with this library; if not, write to the Free Software
17  // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18  ///////////////////////////////////////////////////////////////////////////////////////////////
19  
20  package com.puppycrawl.tools.checkstyle.checks.imports;
21  
22  import java.util.HashSet;
23  import java.util.Set;
24  
25  import com.puppycrawl.tools.checkstyle.StatelessCheck;
26  import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
27  import com.puppycrawl.tools.checkstyle.api.DetailAST;
28  import com.puppycrawl.tools.checkstyle.api.FullIdent;
29  import com.puppycrawl.tools.checkstyle.api.TokenTypes;
30  
31  /**
32   * <div>
33   * Checks that there are no import statements that use the {@code *} notation.
34   * </div>
35   *
36   * <p>
37   * Rationale: Importing all classes from a package or static
38   * members from a class leads to tight coupling between packages
39   * or classes and might lead to problems when a new version of a
40   * library introduces name clashes.
41   * </p>
42   *
43   * <p>
44   * Note that property {@code excludes} is not recursive, subpackages of excluded
45   * packages are not automatically excluded.
46   * </p>
47   * <ul>
48   * <li>
49   * Property {@code allowClassImports} - Control whether to allow starred class
50   * imports like {@code import java.util.*;}.
51   * Type is {@code boolean}.
52   * Default value is {@code false}.
53   * </li>
54   * <li>
55   * Property {@code allowStaticMemberImports} - Control whether to allow starred
56   * static member imports like {@code import static org.junit.Assert.*;}.
57   * Type is {@code boolean}.
58   * Default value is {@code false}.
59   * </li>
60   * <li>
61   * Property {@code excludes} - Specify packages where starred class imports are
62   * allowed and classes where starred static member imports are allowed.
63   * Type is {@code java.lang.String[]}.
64   * Default value is {@code ""}.
65   * </li>
66   * </ul>
67   *
68   * <p>
69   * Parent is {@code com.puppycrawl.tools.checkstyle.TreeWalker}
70   * </p>
71   *
72   * <p>
73   * Violation Message Keys:
74   * </p>
75   * <ul>
76   * <li>
77   * {@code import.avoidStar}
78   * </li>
79   * </ul>
80   *
81   * @since 3.0
82   */
83  @StatelessCheck
84  public class AvoidStarImportCheck
85      extends AbstractCheck {
86  
87      /**
88       * A key is pointing to the warning message text in "messages.properties"
89       * file.
90       */
91      public static final String MSG_KEY = "import.avoidStar";
92  
93      /** Suffix for the star import. */
94      private static final String STAR_IMPORT_SUFFIX = ".*";
95  
96      /**
97       * Specify packages where starred class imports are
98       * allowed and classes where starred static member imports are allowed.
99       */
100     private final Set<String> excludes = new HashSet<>();
101 
102     /**
103      * Control whether to allow starred class imports like
104      * {@code import java.util.*;}.
105      */
106     private boolean allowClassImports;
107 
108     /**
109      * Control whether to allow starred static member imports like
110      * {@code import static org.junit.Assert.*;}.
111      */
112     private boolean allowStaticMemberImports;
113 
114     @Override
115     public int[] getDefaultTokens() {
116         return getRequiredTokens();
117     }
118 
119     @Override
120     public int[] getAcceptableTokens() {
121         return getRequiredTokens();
122     }
123 
124     @Override
125     public int[] getRequiredTokens() {
126         // original implementation checks both IMPORT and STATIC_IMPORT tokens to avoid ".*" imports
127         // however user can allow using "import" or "import static"
128         // by configuring allowClassImports and allowStaticMemberImports
129         // To avoid potential confusion when user specifies conflicting options on configuration
130         // (see example below) we are adding both tokens to Required list
131         //   <module name="AvoidStarImport">
132         //      <property name="tokens" value="IMPORT"/>
133         //      <property name="allowStaticMemberImports" value="false"/>
134         //   </module>
135         return new int[] {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT};
136     }
137 
138     /**
139      * Setter to specify packages where starred class imports are
140      * allowed and classes where starred static member imports are allowed.
141      *
142      * @param excludesParam package names/fully-qualifies class names
143      *     where star imports are ok
144      * @since 3.2
145      */
146     public void setExcludes(String... excludesParam) {
147         for (final String exclude : excludesParam) {
148             if (exclude.endsWith(STAR_IMPORT_SUFFIX)) {
149                 excludes.add(exclude);
150             }
151             else {
152                 excludes.add(exclude + STAR_IMPORT_SUFFIX);
153             }
154         }
155     }
156 
157     /**
158      * Setter to control whether to allow starred class imports like
159      * {@code import java.util.*;}.
160      *
161      * @param allow true to allow false to disallow
162      * @since 5.3
163      */
164     public void setAllowClassImports(boolean allow) {
165         allowClassImports = allow;
166     }
167 
168     /**
169      * Setter to control whether to allow starred static member imports like
170      * {@code import static org.junit.Assert.*;}.
171      *
172      * @param allow true to allow false to disallow
173      * @since 5.3
174      */
175     public void setAllowStaticMemberImports(boolean allow) {
176         allowStaticMemberImports = allow;
177     }
178 
179     @Override
180     public void visitToken(final DetailAST ast) {
181         if (ast.getType() == TokenTypes.IMPORT) {
182             if (!allowClassImports) {
183                 final DetailAST startingDot = ast.getFirstChild();
184                 logsStarredImportViolation(startingDot);
185             }
186         }
187         else if (!allowStaticMemberImports) {
188             // must navigate past the static keyword
189             final DetailAST startingDot = ast.getFirstChild().getNextSibling();
190             logsStarredImportViolation(startingDot);
191         }
192     }
193 
194     /**
195      * Gets the full import identifier.  If the import is a starred import and
196      * it's not excluded then a violation is logged.
197      *
198      * @param startingDot the starting dot for the import statement
199      */
200     private void logsStarredImportViolation(DetailAST startingDot) {
201         final FullIdent name = FullIdent.createFullIdent(startingDot);
202         final String importText = name.getText();
203         if (importText.endsWith(STAR_IMPORT_SUFFIX) && !excludes.contains(importText)) {
204             log(startingDot, MSG_KEY, importText);
205         }
206     }
207 
208 }