1 ///////////////////////////////////////////////////////////////////////////////////////////////
2 // checkstyle: Checks Java source code and other text files for adherence to a set of rules.
3 // Copyright (C) 2001-2026 the original author or authors.
4 //
5 // This library is free software; you can redistribute it and/or
6 // modify it under the terms of the GNU Lesser General Public
7 // License as published by the Free Software Foundation; either
8 // version 2.1 of the License, or (at your option) any later version.
9 //
10 // This library is distributed in the hope that it will be useful,
11 // but WITHOUT ANY WARRANTY; without even the implied warranty of
12 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 // Lesser General Public License for more details.
14 //
15 // You should have received a copy of the GNU Lesser General Public
16 // License along with this library; if not, write to the Free Software
17 // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
18 ///////////////////////////////////////////////////////////////////////////////////////////////
19
20 package com.puppycrawl.tools.checkstyle.checks.coding;
21
22 import java.util.ArrayList;
23 import java.util.Collections;
24 import java.util.List;
25 import java.util.Optional;
26
27 import com.puppycrawl.tools.checkstyle.StatelessCheck;
28 import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
29 import com.puppycrawl.tools.checkstyle.api.DetailAST;
30 import com.puppycrawl.tools.checkstyle.api.TokenTypes;
31 import com.puppycrawl.tools.checkstyle.utils.TokenUtil;
32
33 /**
34 * <div>
35 * Ensures that {@code when} is used instead of a single {@code if}
36 * statement inside a case block.
37 * </div>
38 *
39 * <p>
40 * Rationale: Java 21 has introduced enhancements for switch statements and expressions
41 * that allow the use of patterns in case labels. The {@code when} keyword is used to specify
42 * condition for a case label, also called as guarded case labels. This syntax is more readable
43 * and concise than the single {@code if} statement inside the pattern match block.
44 * </p>
45 *
46 * <p>
47 * See the <a href="https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-Guard">
48 * Java Language Specification</a> for more information about guarded case labels.
49 * </p>
50 *
51 * <p>
52 * See the <a href="https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-14.30">
53 * Java Language Specification</a> for more information about patterns.
54 * </p>
55 *
56 * @since 10.18.0
57 */
58
59 @StatelessCheck
60 public class WhenShouldBeUsedCheck extends AbstractCheck {
61
62 /**
63 * A key is pointing to the warning message text in "messages.properties"
64 * file.
65 */
66 public static final String MSG_KEY = "when.should.be.used";
67
68 @Override
69 public int[] getDefaultTokens() {
70 return getRequiredTokens();
71 }
72
73 @Override
74 public int[] getAcceptableTokens() {
75 return getRequiredTokens();
76 }
77
78 @Override
79 public int[] getRequiredTokens() {
80 return new int[] {TokenTypes.LITERAL_CASE};
81 }
82
83 @Override
84 public void visitToken(DetailAST ast) {
85 final boolean hasPatternLabel = hasPatternLabel(ast);
86 // until https://github.com/checkstyle/checkstyle/issues/15270
87 final boolean isInSwitchRule = ast.getParent().getType() == TokenTypes.SWITCH_RULE;
88
89 final Optional<DetailAST> statementList = getStatementList(ast);
90
91 if (hasPatternLabel && isInSwitchRule && statementList.isPresent()) {
92 final List<DetailAST> blockStatements = getBlockStatements(statementList.get());
93
94 final boolean hasAcceptableStatementsOnly = blockStatements.stream()
95 .allMatch(WhenShouldBeUsedCheck::isAcceptableStatement);
96
97 final boolean hasSingleIfWithNoElse = blockStatements.stream()
98 .filter(WhenShouldBeUsedCheck::isSingleIfWithNoElse)
99 .count() == 1;
100
101 if (hasAcceptableStatementsOnly && hasSingleIfWithNoElse) {
102 log(ast, MSG_KEY);
103 }
104 }
105 }
106
107 /**
108 * Get the statement list token of the case block.
109 *
110 * @param caseAST the AST node representing {@code LITERAL_CASE}
111 * @return Optional containing the AST node representing {@code SLIST} of the current case
112 */
113 private static Optional<DetailAST> getStatementList(DetailAST caseAST) {
114 final DetailAST caseParent = caseAST.getParent();
115 return Optional.ofNullable(caseParent.findFirstToken(TokenTypes.SLIST));
116 }
117
118 /**
119 * Get all statements inside the case block.
120 *
121 * @param statementList the AST node representing {@code SLIST} of the current case
122 * @return statements inside the current case block
123 */
124 private static List<DetailAST> getBlockStatements(DetailAST statementList) {
125 final List<DetailAST> blockStatements = new ArrayList<>();
126 DetailAST ast = statementList.getFirstChild();
127 while (ast != null) {
128 blockStatements.add(ast);
129 ast = ast.getNextSibling();
130 }
131 return Collections.unmodifiableList(blockStatements);
132 }
133
134 /**
135 * Check if the statement is an acceptable statement inside the case block.
136 * If these statements are the only ones in the case block, this case
137 * can be considered a violation. If at least one of the statements
138 * is not acceptable, this case can not be a violation.
139 *
140 * @param ast the AST node representing the statement
141 * @return true if the statement is an acceptable statement, false otherwise
142 */
143 private static boolean isAcceptableStatement(DetailAST ast) {
144 final int[] acceptableChildrenOfSlist = {
145 TokenTypes.LITERAL_IF,
146 TokenTypes.LITERAL_BREAK,
147 TokenTypes.EMPTY_STAT,
148 TokenTypes.RCURLY,
149 };
150 return TokenUtil.isOfType(ast, acceptableChildrenOfSlist);
151 }
152
153 /**
154 * Check if the case block has a pattern variable definition
155 * or a record pattern definition.
156 *
157 * @param caseAST the AST node representing {@code LITERAL_CASE}
158 * @return true if the case block has a pattern label, false otherwise
159 */
160 private static boolean hasPatternLabel(DetailAST caseAST) {
161 return caseAST.findFirstToken(TokenTypes.PATTERN_VARIABLE_DEF) != null
162 || caseAST.findFirstToken(TokenTypes.RECORD_PATTERN_DEF) != null
163 || caseAST.findFirstToken(TokenTypes.PATTERN_DEF) != null;
164 }
165
166 /**
167 * Check if the case block statement is a single if statement with no else branch.
168 *
169 * @param statement statement to check inside the current case block
170 * @return true if the statement is a single if statement with no else branch, false otherwise
171 */
172 private static boolean isSingleIfWithNoElse(DetailAST statement) {
173 return statement.getType() == TokenTypes.LITERAL_IF
174 && statement.findFirstToken(TokenTypes.LITERAL_ELSE) == null;
175 }
176
177 }