View Javadoc
1   ///////////////////////////////////////////////////////////////////////////////////////////////
2   // checkstyle: Checks Java source code and other text files for adherence to a set of rules.
3   // Copyright (C) 2001-2025 the original author or authors.
4   //
5   // This library is free software; you can redistribute it and/or
6   // modify it under the terms of the GNU Lesser General Public
7   // License as published by the Free Software Foundation; either
8   // version 2.1 of the License, or (at your option) any later version.
9   //
10  // This library is distributed in the hope that it will be useful,
11  // but WITHOUT ANY WARRANTY; without even the implied warranty of
12  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
13  // Lesser General Public License for more details.
14  //
15  // You should have received a copy of the GNU Lesser General Public
16  // License along with this library; if not, write to the Free Software
17  // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18  ///////////////////////////////////////////////////////////////////////////////////////////////
19  
20  package com.puppycrawl.tools.checkstyle.checks.coding;
21  
22  import com.puppycrawl.tools.checkstyle.StatelessCheck;
23  import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
24  import com.puppycrawl.tools.checkstyle.api.DetailAST;
25  import com.puppycrawl.tools.checkstyle.api.TokenTypes;
26  import com.puppycrawl.tools.checkstyle.utils.CommonUtil;
27  import com.puppycrawl.tools.checkstyle.utils.ScopeUtil;
28  
29  /**
30   * <div>
31   * Checks if unnecessary semicolon is used after type member declaration.
32   * </div>
33   *
34   * <p>
35   * Notes:
36   * This check is not applicable to empty statements (unnecessary semicolons inside methods or
37   * init blocks),
38   * <a href="https://checkstyle.org/checks/coding/emptystatement.html">EmptyStatement</a>
39   * is responsible for it.
40   * </p>
41   *
42   * @since 8.24
43   */
44  @StatelessCheck
45  public final class UnnecessarySemicolonAfterTypeMemberDeclarationCheck extends AbstractCheck {
46  
47      /**
48       * A key is pointing to the warning message text in "messages.properties"
49       * file.
50       */
51      public static final String MSG_SEMI = "unnecessary.semicolon";
52  
53      @Override
54      public int[] getDefaultTokens() {
55          return getAcceptableTokens();
56      }
57  
58      @Override
59      public int[] getAcceptableTokens() {
60          return new int[] {
61              TokenTypes.CLASS_DEF,
62              TokenTypes.INTERFACE_DEF,
63              TokenTypes.ENUM_DEF,
64              TokenTypes.ANNOTATION_DEF,
65              TokenTypes.VARIABLE_DEF,
66              TokenTypes.ANNOTATION_FIELD_DEF,
67              TokenTypes.STATIC_INIT,
68              TokenTypes.INSTANCE_INIT,
69              TokenTypes.CTOR_DEF,
70              TokenTypes.METHOD_DEF,
71              TokenTypes.ENUM_CONSTANT_DEF,
72              TokenTypes.COMPACT_CTOR_DEF,
73              TokenTypes.RECORD_DEF,
74          };
75      }
76  
77      @Override
78      public int[] getRequiredTokens() {
79          return CommonUtil.EMPTY_INT_ARRAY;
80      }
81  
82      @Override
83      public void visitToken(DetailAST ast) {
84          switch (ast.getType()) {
85              case TokenTypes.CLASS_DEF,
86                   TokenTypes.INTERFACE_DEF,
87                   TokenTypes.ENUM_DEF,
88                   TokenTypes.ANNOTATION_DEF,
89                   TokenTypes.RECORD_DEF -> checkTypeDefinition(ast);
90              case TokenTypes.VARIABLE_DEF -> checkVariableDefinition(ast);
91              case TokenTypes.ENUM_CONSTANT_DEF -> checkEnumConstant(ast);
92              default -> checkTypeMember(ast);
93          }
94      }
95  
96      /**
97       * Checks if type member has unnecessary semicolon.
98       *
99       * @param ast type member
100      */
101     private void checkTypeMember(DetailAST ast) {
102         if (isSemicolon(ast.getNextSibling())) {
103             log(ast.getNextSibling(), MSG_SEMI);
104         }
105     }
106 
107     /**
108      * Checks if type definition has unnecessary semicolon.
109      *
110      * @param ast type definition
111      */
112     private void checkTypeDefinition(DetailAST ast) {
113         if (!ScopeUtil.isOuterMostType(ast) && isSemicolon(ast.getNextSibling())) {
114             log(ast.getNextSibling(), MSG_SEMI);
115         }
116         final DetailAST firstMember =
117             ast.findFirstToken(TokenTypes.OBJBLOCK).getFirstChild().getNextSibling();
118         if (isSemicolon(firstMember) && !ScopeUtil.isInEnumBlock(firstMember)) {
119             log(firstMember, MSG_SEMI);
120         }
121     }
122 
123     /**
124      * Checks if variable definition has unnecessary semicolon.
125      *
126      * @param variableDef variable definition
127      */
128     private void checkVariableDefinition(DetailAST variableDef) {
129         if (isSemicolon(variableDef.getLastChild()) && isSemicolon(variableDef.getNextSibling())) {
130             log(variableDef.getNextSibling(), MSG_SEMI);
131         }
132     }
133 
134     /**
135      * Checks if enum constant has unnecessary semicolon.
136      *
137      * @param ast enum constant
138      */
139     private void checkEnumConstant(DetailAST ast) {
140         final DetailAST next = ast.getNextSibling();
141         if (isSemicolon(next) && isSemicolon(next.getNextSibling())) {
142             log(next.getNextSibling(), MSG_SEMI);
143         }
144     }
145 
146     /**
147      * Checks that {@code ast} is a semicolon.
148      *
149      * @param ast token to check
150      * @return true if ast is semicolon, false otherwise
151      */
152     private static boolean isSemicolon(DetailAST ast) {
153         return ast != null && ast.getType() == TokenTypes.SEMI;
154     }
155 }