View Javadoc
1   ///////////////////////////////////////////////////////////////////////////////////////////////
2   // checkstyle: Checks Java source code and other text files for adherence to a set of rules.
3   // Copyright (C) 2001-2024 the original author or authors.
4   //
5   // This library is free software; you can redistribute it and/or
6   // modify it under the terms of the GNU Lesser General Public
7   // License as published by the Free Software Foundation; either
8   // version 2.1 of the License, or (at your option) any later version.
9   //
10  // This library is distributed in the hope that it will be useful,
11  // but WITHOUT ANY WARRANTY; without even the implied warranty of
12  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
13  // Lesser General Public License for more details.
14  //
15  // You should have received a copy of the GNU Lesser General Public
16  // License along with this library; if not, write to the Free Software
17  // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18  ///////////////////////////////////////////////////////////////////////////////////////////////
19  
20  package com.puppycrawl.tools.checkstyle.checks.coding;
21  
22  import com.puppycrawl.tools.checkstyle.StatelessCheck;
23  import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
24  import com.puppycrawl.tools.checkstyle.api.DetailAST;
25  import com.puppycrawl.tools.checkstyle.api.TokenTypes;
26  import com.puppycrawl.tools.checkstyle.utils.CheckUtil;
27  import com.puppycrawl.tools.checkstyle.utils.ScopeUtil;
28  
29  /**
30   * <p>
31   * Checks if any class or object member is explicitly initialized
32   * to default for its type value ({@code null} for object
33   * references, zero for numeric types and {@code char}
34   * and {@code false} for {@code boolean}.
35   * </p>
36   * <p>
37   * Rationale: Each instance variable gets
38   * initialized twice, to the same value. Java
39   * initializes each instance variable to its default
40   * value ({@code 0} or {@code null}) before performing any
41   * initialization specified in the code.
42   * So there is a minor inefficiency.
43   * </p>
44   * <ul>
45   * <li>
46   * Property {@code onlyObjectReferences} - Control whether only explicit
47   * initializations made to null for objects should be checked.
48   * Type is {@code boolean}.
49   * Default value is {@code false}.
50   * </li>
51   * </ul>
52   * <p>
53   * Parent is {@code com.puppycrawl.tools.checkstyle.TreeWalker}
54   * </p>
55   * <p>
56   * Violation Message Keys:
57   * </p>
58   * <ul>
59   * <li>
60   * {@code explicit.init}
61   * </li>
62   * </ul>
63   *
64   * @since 3.2
65   */
66  @StatelessCheck
67  public class ExplicitInitializationCheck extends AbstractCheck {
68  
69      /**
70       * A key is pointing to the warning message text in "messages.properties"
71       * file.
72       */
73      public static final String MSG_KEY = "explicit.init";
74  
75      /**
76       * Control whether only explicit initializations made to null for objects should be checked.
77       **/
78      private boolean onlyObjectReferences;
79  
80      @Override
81      public final int[] getDefaultTokens() {
82          return getRequiredTokens();
83      }
84  
85      @Override
86      public final int[] getRequiredTokens() {
87          return new int[] {TokenTypes.VARIABLE_DEF};
88      }
89  
90      @Override
91      public final int[] getAcceptableTokens() {
92          return getRequiredTokens();
93      }
94  
95      /**
96       * Setter to control whether only explicit initializations made to null
97       * for objects should be checked.
98       *
99       * @param onlyObjectReferences whether only explicit initialization made to null
100      *                             should be checked
101      * @since 7.8
102      */
103     public void setOnlyObjectReferences(boolean onlyObjectReferences) {
104         this.onlyObjectReferences = onlyObjectReferences;
105     }
106 
107     @Override
108     public void visitToken(DetailAST ast) {
109         if (!isSkipCase(ast)) {
110             final DetailAST assign = ast.findFirstToken(TokenTypes.ASSIGN);
111             final DetailAST exprStart =
112                 assign.getFirstChild().getFirstChild();
113             if (exprStart.getType() == TokenTypes.LITERAL_NULL) {
114                 final DetailAST ident = ast.findFirstToken(TokenTypes.IDENT);
115                 log(ident, MSG_KEY, ident.getText(), "null");
116             }
117             if (!onlyObjectReferences) {
118                 validateNonObjects(ast);
119             }
120         }
121     }
122 
123     /**
124      * Checks for explicit initializations made to 'false', '0' and '\0'.
125      *
126      * @param ast token being checked for explicit initializations
127      */
128     private void validateNonObjects(DetailAST ast) {
129         final DetailAST ident = ast.findFirstToken(TokenTypes.IDENT);
130         final DetailAST assign = ast.findFirstToken(TokenTypes.ASSIGN);
131         final DetailAST exprStart =
132                 assign.getFirstChild().getFirstChild();
133         final DetailAST type = ast.findFirstToken(TokenTypes.TYPE);
134         final int primitiveType = type.getFirstChild().getType();
135         if (primitiveType == TokenTypes.LITERAL_BOOLEAN
136                 && exprStart.getType() == TokenTypes.LITERAL_FALSE) {
137             log(ident, MSG_KEY, ident.getText(), "false");
138         }
139         if (isNumericType(primitiveType) && isZero(exprStart)) {
140             log(ident, MSG_KEY, ident.getText(), "0");
141         }
142         if (primitiveType == TokenTypes.LITERAL_CHAR
143                 && isZeroChar(exprStart)) {
144             log(ident, MSG_KEY, ident.getText(), "\\0");
145         }
146     }
147 
148     /**
149      * Examine char literal for initializing to default value.
150      *
151      * @param exprStart expression
152      * @return true is literal is initialized by zero symbol
153      */
154     private static boolean isZeroChar(DetailAST exprStart) {
155         return isZero(exprStart)
156             || "'\\0'".equals(exprStart.getText());
157     }
158 
159     /**
160      * Checks for cases that should be skipped: no assignment, local variable, final variables.
161      *
162      * @param ast Variable def AST
163      * @return true is that is a case that need to be skipped.
164      */
165     private static boolean isSkipCase(DetailAST ast) {
166         boolean skipCase = true;
167 
168         // do not check local variables and
169         // fields declared in interface/annotations
170         if (!ScopeUtil.isLocalVariableDef(ast)
171                 && !ScopeUtil.isInInterfaceOrAnnotationBlock(ast)) {
172             final DetailAST assign = ast.findFirstToken(TokenTypes.ASSIGN);
173 
174             if (assign != null) {
175                 final DetailAST modifiers = ast.findFirstToken(TokenTypes.MODIFIERS);
176                 skipCase = modifiers.findFirstToken(TokenTypes.FINAL) != null;
177             }
178         }
179         return skipCase;
180     }
181 
182     /**
183      * Determine if a given type is a numeric type.
184      *
185      * @param type code of the type for check.
186      * @return true if it's a numeric type.
187      * @see TokenTypes
188      */
189     private static boolean isNumericType(int type) {
190         return type == TokenTypes.LITERAL_BYTE
191                 || type == TokenTypes.LITERAL_SHORT
192                 || type == TokenTypes.LITERAL_INT
193                 || type == TokenTypes.LITERAL_FLOAT
194                 || type == TokenTypes.LITERAL_LONG
195                 || type == TokenTypes.LITERAL_DOUBLE;
196     }
197 
198     /**
199      * Checks if given node contains numeric constant for zero.
200      *
201      * @param expr node to check.
202      * @return true if given node contains numeric constant for zero.
203      */
204     private static boolean isZero(DetailAST expr) {
205         final int type = expr.getType();
206         final boolean isZero;
207         switch (type) {
208             case TokenTypes.NUM_FLOAT:
209             case TokenTypes.NUM_DOUBLE:
210             case TokenTypes.NUM_INT:
211             case TokenTypes.NUM_LONG:
212                 final String text = expr.getText();
213                 isZero = Double.compare(CheckUtil.parseDouble(text, type), 0.0) == 0;
214                 break;
215             default:
216                 isZero = false;
217         }
218         return isZero;
219     }
220 
221 }