1 ///////////////////////////////////////////////////////////////////////////////////////////////
2 // checkstyle: Checks Java source code and other text files for adherence to a set of rules.
3 // Copyright (C) 2001-2026 the original author or authors.
4 //
5 // This library is free software; you can redistribute it and/or
6 // modify it under the terms of the GNU Lesser General Public
7 // License as published by the Free Software Foundation; either
8 // version 2.1 of the License, or (at your option) any later version.
9 //
10 // This library is distributed in the hope that it will be useful,
11 // but WITHOUT ANY WARRANTY; without even the implied warranty of
12 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 // Lesser General Public License for more details.
14 //
15 // You should have received a copy of the GNU Lesser General Public
16 // License along with this library; if not, write to the Free Software
17 // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
18 ///////////////////////////////////////////////////////////////////////////////////////////////
19
20 package com.puppycrawl.tools.checkstyle.checks.coding;
21
22 import java.util.ArrayList;
23 import java.util.List;
24 import java.util.Optional;
25
26 import com.puppycrawl.tools.checkstyle.StatelessCheck;
27 import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
28 import com.puppycrawl.tools.checkstyle.api.DetailAST;
29 import com.puppycrawl.tools.checkstyle.api.TokenTypes;
30
31 /**
32 * <div>
33 * Checks that all constructors are grouped together.
34 * If there is any non-constructor code separating constructors,
35 * this check identifies and logs a violation for those ungrouped constructors.
36 * The violation message will specify the line number of the last grouped constructor.
37 * Comments between constructors are allowed.
38 * </div>
39 *
40 * <p>
41 * Rationale: Grouping constructors together in a class improves code readability
42 * and maintainability. It allows developers to easily understand
43 * the different ways an object can be instantiated
44 * and the tasks performed by each constructor.
45 * </p>
46 *
47 * @since 10.17.0
48 */
49
50 @StatelessCheck
51 public class ConstructorsDeclarationGroupingCheck extends AbstractCheck {
52
53 /**
54 * A key is pointing to the warning message text in "messages.properties"
55 * file.
56 */
57 public static final String MSG_KEY = "constructors.declaration.grouping";
58
59 /**
60 * A key is pointing to the warning message text in "messages.properties"
61 * file.
62 */
63 public static final String MSG_ORDER = "constructors.declaration.order";
64
65 /**
66 * Control whether to order constructors by increasing parameter count or not.
67 */
68 private boolean orderByIncreasingParameterCount;
69
70 /**
71 * Setter to control whether to enforce order by increasing parameter count (arity) or not.
72 *
73 * @param orderByIncreasingParameterCount true if order by increasing parameter
74 * count is required.
75 * @since 13.6.0
76 */
77 public void setOrderByIncreasingParameterCount(boolean orderByIncreasingParameterCount) {
78 this.orderByIncreasingParameterCount = orderByIncreasingParameterCount;
79 }
80
81 @Override
82 public int[] getDefaultTokens() {
83 return getRequiredTokens();
84 }
85
86 @Override
87 public int[] getAcceptableTokens() {
88 return getRequiredTokens();
89 }
90
91 @Override
92 public int[] getRequiredTokens() {
93 return new int[] {
94 TokenTypes.CLASS_DEF,
95 TokenTypes.ENUM_DEF,
96 TokenTypes.RECORD_DEF,
97 };
98 }
99
100 @Override
101 public void visitToken(DetailAST ast) {
102 // list of all child ASTs
103 final List<DetailAST> children = getChildList(ast);
104
105 // find first constructor
106 final DetailAST firstConstructor = children.stream()
107 .filter(ConstructorsDeclarationGroupingCheck::isConstructor)
108 .findFirst()
109 .orElse(null);
110
111 if (firstConstructor != null) {
112
113 // get all children AST after the first constructor
114 final List<DetailAST> childrenAfterFirstConstructor =
115 children.subList(children.indexOf(firstConstructor), children.size());
116
117 // find the first index of non-constructor AST after the first constructor, if present
118 final Optional<Integer> indexOfFirstNonConstructor = childrenAfterFirstConstructor
119 .stream()
120 .filter(currAst -> !isConstructor(currAst))
121 .findFirst()
122 .map(children::indexOf);
123
124 // list of all children after first non-constructor AST
125 final List<DetailAST> childrenAfterFirstNonConstructor = indexOfFirstNonConstructor
126 .map(index -> children.subList(index, children.size()))
127 .orElseGet(ArrayList::new);
128
129 // create a list of all constructors that are not grouped to log
130 final List<DetailAST> constructorsToLog = childrenAfterFirstNonConstructor.stream()
131 .filter(ConstructorsDeclarationGroupingCheck::isConstructor)
132 .toList();
133
134 // find the last grouped constructor
135 final DetailAST lastGroupedConstructor = childrenAfterFirstConstructor.stream()
136 .takeWhile(ConstructorsDeclarationGroupingCheck::isConstructor)
137 .reduce((first, second) -> second)
138 .orElse(firstConstructor);
139
140 // log all constructors that are not grouped
141 constructorsToLog
142 .forEach(ctor -> log(ctor, MSG_KEY, lastGroupedConstructor.getLineNo()));
143
144 if (orderByIncreasingParameterCount) {
145
146 // list of all constructor ASTs
147 final List<DetailAST> allConstructors = children.stream()
148 .filter(ConstructorsDeclarationGroupingCheck::isConstructor)
149 .toList();
150
151 int previousParamCount = 0;
152 boolean isOrdered = true;
153 for (DetailAST constructor : allConstructors) {
154 final int currentParamCount = getParameterCount(constructor);
155 isOrdered = isOrdered && currentParamCount >= previousParamCount;
156 previousParamCount = currentParamCount;
157 if (!isOrdered) {
158 log(constructor, MSG_ORDER);
159 }
160 }
161 }
162 }
163 }
164
165 /**
166 * Get a list of all children of the given AST.
167 *
168 * @param ast the AST to get children of
169 * @return a list of all children of the given AST
170 */
171 private static List<DetailAST> getChildList(DetailAST ast) {
172 final List<DetailAST> children = new ArrayList<>();
173 DetailAST child = ast.findFirstToken(TokenTypes.OBJBLOCK).getFirstChild();
174 while (child != null) {
175 children.add(child);
176 child = child.getNextSibling();
177 }
178 return children;
179 }
180
181 /**
182 * Check if the given AST is a constructor.
183 *
184 * @param ast the AST to check
185 * @return true if the given AST is a constructor, false otherwise
186 */
187 private static boolean isConstructor(DetailAST ast) {
188 return ast.getType() == TokenTypes.CTOR_DEF
189 || ast.getType() == TokenTypes.COMPACT_CTOR_DEF;
190 }
191
192 /**
193 * Get the parameter count of a constructor.
194 *
195 * @param constructor the constructor AST
196 * @return the parameter count of the constructor
197 */
198 private static int getParameterCount(DetailAST constructor) {
199 final DetailAST params = constructor.findFirstToken(TokenTypes.PARAMETERS);
200 int parameterCount = 0;
201 if (params != null) {
202 parameterCount = params.getChildCount(TokenTypes.PARAMETER_DEF);
203 }
204 return parameterCount;
205 }
206 }