001/////////////////////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code and other text files for adherence to a set of rules. 003// Copyright (C) 2001-2026 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018/////////////////////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.coding; 021 022import java.util.ArrayList; 023import java.util.Collections; 024import java.util.List; 025import java.util.Optional; 026 027import com.puppycrawl.tools.checkstyle.StatelessCheck; 028import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 029import com.puppycrawl.tools.checkstyle.api.DetailAST; 030import com.puppycrawl.tools.checkstyle.api.TokenTypes; 031import com.puppycrawl.tools.checkstyle.utils.TokenUtil; 032 033/** 034 * <div> 035 * Ensures that {@code when} is used instead of a single {@code if} 036 * statement inside a case block. 037 * </div> 038 * 039 * <p> 040 * Rationale: Java 21 has introduced enhancements for switch statements and expressions 041 * that allow the use of patterns in case labels. The {@code when} keyword is used to specify 042 * condition for a case label, also called as guarded case labels. This syntax is more readable 043 * and concise than the single {@code if} statement inside the pattern match block. 044 * </p> 045 * 046 * <p> 047 * See the <a href="https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-Guard"> 048 * Java Language Specification</a> for more information about guarded case labels. 049 * </p> 050 * 051 * <p> 052 * See the <a href="https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-14.30"> 053 * Java Language Specification</a> for more information about patterns. 054 * </p> 055 * 056 * @since 10.18.0 057 */ 058 059@StatelessCheck 060public class WhenShouldBeUsedCheck extends AbstractCheck { 061 062 /** 063 * A key is pointing to the warning message text in "messages.properties" 064 * file. 065 */ 066 public static final String MSG_KEY = "when.should.be.used"; 067 068 @Override 069 public int[] getDefaultTokens() { 070 return getRequiredTokens(); 071 } 072 073 @Override 074 public int[] getAcceptableTokens() { 075 return getRequiredTokens(); 076 } 077 078 @Override 079 public int[] getRequiredTokens() { 080 return new int[] {TokenTypes.LITERAL_CASE}; 081 } 082 083 @Override 084 public void visitToken(DetailAST ast) { 085 final boolean hasPatternLabel = hasPatternLabel(ast); 086 // until https://github.com/checkstyle/checkstyle/issues/15270 087 final boolean isInSwitchRule = ast.getParent().getType() == TokenTypes.SWITCH_RULE; 088 089 final Optional<DetailAST> statementList = getStatementList(ast); 090 091 if (hasPatternLabel && isInSwitchRule && statementList.isPresent()) { 092 final List<DetailAST> blockStatements = getBlockStatements(statementList.get()); 093 094 final boolean hasAcceptableStatementsOnly = blockStatements.stream() 095 .allMatch(WhenShouldBeUsedCheck::isAcceptableStatement); 096 097 final boolean hasSingleIfWithNoElse = blockStatements.stream() 098 .filter(WhenShouldBeUsedCheck::isSingleIfWithNoElse) 099 .count() == 1; 100 101 if (hasAcceptableStatementsOnly && hasSingleIfWithNoElse) { 102 log(ast, MSG_KEY); 103 } 104 } 105 } 106 107 /** 108 * Get the statement list token of the case block. 109 * 110 * @param caseAST the AST node representing {@code LITERAL_CASE} 111 * @return Optional containing the AST node representing {@code SLIST} of the current case 112 */ 113 private static Optional<DetailAST> getStatementList(DetailAST caseAST) { 114 final DetailAST caseParent = caseAST.getParent(); 115 return Optional.ofNullable(caseParent.findFirstToken(TokenTypes.SLIST)); 116 } 117 118 /** 119 * Get all statements inside the case block. 120 * 121 * @param statementList the AST node representing {@code SLIST} of the current case 122 * @return statements inside the current case block 123 */ 124 private static List<DetailAST> getBlockStatements(DetailAST statementList) { 125 final List<DetailAST> blockStatements = new ArrayList<>(); 126 DetailAST ast = statementList.getFirstChild(); 127 while (ast != null) { 128 blockStatements.add(ast); 129 ast = ast.getNextSibling(); 130 } 131 return Collections.unmodifiableList(blockStatements); 132 } 133 134 /** 135 * Check if the statement is an acceptable statement inside the case block. 136 * If these statements are the only ones in the case block, this case 137 * can be considered a violation. If at least one of the statements 138 * is not acceptable, this case can not be a violation. 139 * 140 * @param ast the AST node representing the statement 141 * @return true if the statement is an acceptable statement, false otherwise 142 */ 143 private static boolean isAcceptableStatement(DetailAST ast) { 144 final int[] acceptableChildrenOfSlist = { 145 TokenTypes.LITERAL_IF, 146 TokenTypes.LITERAL_BREAK, 147 TokenTypes.EMPTY_STAT, 148 TokenTypes.RCURLY, 149 }; 150 return TokenUtil.isOfType(ast, acceptableChildrenOfSlist); 151 } 152 153 /** 154 * Check if the case block has a pattern variable definition 155 * or a record pattern definition. 156 * 157 * @param caseAST the AST node representing {@code LITERAL_CASE} 158 * @return true if the case block has a pattern label, false otherwise 159 */ 160 private static boolean hasPatternLabel(DetailAST caseAST) { 161 return caseAST.findFirstToken(TokenTypes.PATTERN_VARIABLE_DEF) != null 162 || caseAST.findFirstToken(TokenTypes.RECORD_PATTERN_DEF) != null 163 || caseAST.findFirstToken(TokenTypes.PATTERN_DEF) != null; 164 } 165 166 /** 167 * Check if the case block statement is a single if statement with no else branch. 168 * 169 * @param statement statement to check inside the current case block 170 * @return true if the statement is a single if statement with no else branch, false otherwise 171 */ 172 private static boolean isSingleIfWithNoElse(DetailAST statement) { 173 return statement.getType() == TokenTypes.LITERAL_IF 174 && statement.findFirstToken(TokenTypes.LITERAL_ELSE) == null; 175 } 176 177}