Class MutableExceptionCheck
- All Implemented Interfaces:
Configurable
,Contextualizable
The current algorithm is very simple: it checks that all members of exception are final.
The user can still mutate an exception's instance (e.g. Throwable has a method called
setStackTrace
which changes the exception's stack trace). But, at least, all
information provided by this exception type is unchangeable.
Rationale: Exception instances should represent an error condition. Having non-final fields not only allows the state to be modified by accident and therefore mask the original condition but also allows developers to accidentally forget to set the initial state. In both cases, code catching the exception could draw incorrect conclusions based on the state.
-
Property
extendedClassNameFormat
- Specify pattern for extended class names. Type isjava.util.regex.Pattern
. Default value is"^.*Exception$|^.*Error$|^.*Throwable$"
. -
Property
format
- Specify pattern for exception class names. Type isjava.util.regex.Pattern
. Default value is"^.*Exception$|^.*Error$|^.*Throwable$"
.
Parent is com.puppycrawl.tools.checkstyle.TreeWalker
Violation Message Keys:
-
mutable.exception
- Since:
- 3.2
-
Nested Class Summary
Nested classes/interfaces inherited from class com.puppycrawl.tools.checkstyle.AbstractAutomaticBean
AbstractAutomaticBean.OutputStreamOptions
-
Field Summary
FieldsModifier and TypeFieldDescriptionprivate boolean
Should we check current class or not.Stack of checking information for classes.private static final String
Default value for format and extendedClassNameFormat properties.private Pattern
Specify pattern for extended class names.private Pattern
Specify pattern for exception class names.static final String
A key is pointing to the warning message text in "messages.properties" file. -
Constructor Summary
Constructors -
Method Summary
Modifier and TypeMethodDescriptionint[]
The configurable token set.int[]
Returns the default token a check is interested in.int[]
The tokens that this check must be registered for.private boolean
Checks that if extended class name conforms to specified format.private boolean
Checks that a class name conforms to specified format.private void
Called when we leave class definition.void
leaveToken
(DetailAST ast) Called after all the child nodes have been process.void
setExtendedClassNameFormat
(Pattern extendedClassNameFormat) Setter to specify pattern for extended class names.void
Setter to specify pattern for exception class names.private void
visitClassDef
(DetailAST ast) Called when we start processing class definition.void
visitToken
(DetailAST ast) Called to process a token.private void
Checks variable definition.Methods inherited from class com.puppycrawl.tools.checkstyle.api.AbstractCheck
beginTree, clearViolations, destroy, finishTree, getFileContents, getFilePath, getLine, getLineCodePoints, getLines, getTabWidth, getTokenNames, getViolations, init, isCommentNodesRequired, log, log, log, setFileContents, setTabWidth, setTokens
Methods inherited from class com.puppycrawl.tools.checkstyle.api.AbstractViolationReporter
finishLocalSetup, getCustomMessages, getId, getMessageBundle, getSeverity, getSeverityLevel, setId, setSeverity
Methods inherited from class com.puppycrawl.tools.checkstyle.AbstractAutomaticBean
configure, contextualize, getConfiguration, setupChild
-
Field Details
-
MSG_KEY
A key is pointing to the warning message text in "messages.properties" file.- See Also:
-
DEFAULT_FORMAT
Default value for format and extendedClassNameFormat properties.- See Also:
-
checkingStack
Stack of checking information for classes. -
extendedClassNameFormat
Specify pattern for extended class names. -
checking
Should we check current class or not. -
format
Specify pattern for exception class names.
-
-
Constructor Details
-
MutableExceptionCheck
public MutableExceptionCheck()
-
-
Method Details
-
setExtendedClassNameFormat
Setter to specify pattern for extended class names.- Parameters:
extendedClassNameFormat
- aString
value- Since:
- 6.2
-
setFormat
Setter to specify pattern for exception class names.- Parameters:
pattern
- the new pattern- Since:
- 3.2
-
getDefaultTokens
Description copied from class:AbstractCheck
Returns the default token a check is interested in. Only used if the configuration for a check does not define the tokens.- Specified by:
getDefaultTokens
in classAbstractCheck
- Returns:
- the default tokens
- See Also:
-
getRequiredTokens
Description copied from class:AbstractCheck
The tokens that this check must be registered for.- Specified by:
getRequiredTokens
in classAbstractCheck
- Returns:
- the token set this must be registered for.
- See Also:
-
getAcceptableTokens
Description copied from class:AbstractCheck
The configurable token set. Used to protect Checks against malicious users who specify an unacceptable token set in the configuration file. The default implementation returns the check's default tokens.- Specified by:
getAcceptableTokens
in classAbstractCheck
- Returns:
- the token set this check is designed for.
- See Also:
-
visitToken
Description copied from class:AbstractCheck
Called to process a token.- Overrides:
visitToken
in classAbstractCheck
- Parameters:
ast
- the token to process
-
leaveToken
Description copied from class:AbstractCheck
Called after all the child nodes have been process.- Overrides:
leaveToken
in classAbstractCheck
- Parameters:
ast
- the token leaving
-
visitClassDef
Called when we start processing class definition.- Parameters:
ast
- class definition node
-
leaveClassDef
Called when we leave class definition. -
visitVariableDef
Checks variable definition.- Parameters:
ast
- variable def node for check
-
isNamedAsException
Checks that a class name conforms to specified format.- Parameters:
ast
- class definition node- Returns:
- true if a class name conforms to specified format
-
isExtendedClassNamedAsException
Checks that if extended class name conforms to specified format.- Parameters:
ast
- class definition node- Returns:
- true if extended class name conforms to specified format
-