AvoidInlineConditionals

Since Checkstyle 3.1

Description

Detects inline conditionals. Here is one example of an inline conditional:

String a = getParameter("a");
String b = (a==null || a.length()<1) ? null : a.substring(1);
        

Rationale: Some developers find inline conditionals hard to read, so their employer's coding standards forbid them.

Examples

To configure the check:

<module name="Checker">
  <module name="TreeWalker">
    <module name="AvoidInlineConditionals"/>
  </module>
</module>
        

Example:

int x = 5;
boolean foobar = (x == 5); // OK

String text;
text = (text == null) ? "" : text; // violation

String b;
if (a != null && a.length() >= 1) { // OK
    b = a.substring(1);
} else {
    b = null;
}

b = (a != null && a.length() >= 1) ? a.substring(1) : null; // violation
        

Example of Usage

Violation Messages

All messages can be customized if the default message doesn't suit you. Please see the documentation to learn how to.

Package

com.puppycrawl.tools.checkstyle.checks.coding

Parent Module

TreeWalker